Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS size test #984

Merged
merged 3 commits into from
Apr 5, 2023
Merged

iOS size test #984

merged 3 commits into from
Apr 5, 2023

Conversation

alexcristici
Copy link
Collaborator

Building the app for 2 configurations: Release and MinSizeRel, and comparing the MapLibre dynamic library size with saved sizes before starting the modularization and migration to Metal.

@alexcristici alexcristici self-assigned this Apr 4, 2023
@alexcristici alexcristici linked an issue Apr 4, 2023 that may be closed by this pull request
Create iOS size test #943
Closed
@sjg-wdw
Copy link
Collaborator

sjg-wdw commented Apr 4, 2023

Over the years Xcode has moved its build around, changed its arguments and such.
I wonder if you could put some checks around the xcode invocation and double check that the build directory exists.

TimSylvester
TimSylvester approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@TimSylvester TimSylvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're depending on the signing key being set up in the test runner, right? I don't see anything about it here, which is good.

@alexcristici
Copy link
Collaborator Author

We're depending on the signing key being set up in the test runner, right? I don't see anything about it here, which is good.

Yes, the command line for running the size test is: make ios-sizetest DEV_TEAM=[TEAM_ID]. Maybe we will change to use the prov and signing certificate directly if needed. We will see when we will reach the point to add it on GitHub CI.

@sjg-wdw
Copy link
Collaborator

sjg-wdw commented Apr 4, 2023

Over the years Xcode has moved its build around, changed its arguments and such. I wonder if you could put some checks around the xcode invocation and double check that the build directory exists.

To provide a bit more context, I've had framework building scripts that have broken several times over the years and it's never clear why. It would be nice to provide whomever deals with this in 3 years a starting point for which part of it is failing.

@alexcristici
Copy link
Collaborator Author

Over the years Xcode has moved its build around, changed its arguments and such. I wonder if you could put some checks around the xcode invocation and double check that the build directory exists.

To provide a bit more context, I've had framework building scripts that have broken several times over the years and it's never clear why. It would be nice to provide whomever deals with this in 3 years a starting point for which part of it is failing.

Yes, I added checks after each step. Let me know if I missed something.

@sjg-wdw
Copy link
Collaborator

sjg-wdw commented Apr 4, 2023

Over the years Xcode has moved its build around, changed its arguments and such. I wonder if you could put some checks around the xcode invocation and double check that the build directory exists.

To provide a bit more context, I've had framework building scripts that have broken several times over the years and it's never clear why. It would be nice to provide whomever deals with this in 3 years a starting point for which part of it is failing.

Yes, I added checks after each step. Let me know if I missed something.

Looks great!

louwers
louwers approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t try this out yet but LGTM.

Feel free to merge.

@alexcristici alexcristici merged commit 7138a8f into maplibre:main Apr 5, 2023
@alexcristici alexcristici deleted the ios-size-test branch April 5, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louwers louwers louwers approved these changes

@mwilsnd mwilsnd mwilsnd approved these changes

@TimSylvester TimSylvester TimSylvester approved these changes

@sjg-wdw sjg-wdw sjg-wdw approved these changes

@ovivoda ovivoda Awaiting requested review from ovivoda

Assignees

@alexcristici alexcristici

Labels
iOS
Projects
MapLibre Native Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create iOS size test
5 participants
@alexcristici @sjg-wdw @louwers @mwilsnd @TimSylvester